-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
We have to document that this is a breaking change.
@yanns thank you for approving. Do we have any process for documenting breaking changes in place? |
@kirach no there's no process. |
@yanns got it, thank you! Let me know if you need help with anything else. |
Thanks guys, this is fantastic! I've been hoping to get this merged for almost a year. |
This PR introduces an issue in one application:
With such a query:
I'll search for the root cause. |
@yanns yeah I know what's the root of this issue - I fixed it the internal fork of sanria we're using at our company. I can open another PR to backport it here as well. |
@kirach yes please |
I'll revert this PR as it breaks productive applications. |
This reverts commit f9b9219 as it introduced an issue: #10 (comment)
The copy of sangria-graphql#430 for this repo.
All credits goes to @robconrad. I've just moved the changes and resolved the conflicts.
From the original PR: